Skip to content

Fix View Indexes not Scaffolded in Sql Server#37607

Merged
AndriySvyryd merged 1 commit intodotnet:release/10.0from
sarbas33:fix-sqlserver-scaffold-view-index
Feb 4, 2026
Merged

Fix View Indexes not Scaffolded in Sql Server#37607
AndriySvyryd merged 1 commit intodotnet:release/10.0from
sarbas33:fix-sqlserver-scaffold-view-index

Conversation

@sarbas33
Copy link

@sarbas33 sarbas33 commented Feb 1, 2026 •
edited
Loading

  • I've read the guidelines for contributing and seen the walkthrough
  • I've posted a comment on an issue with a detailed description of how I am planning to contribute and got approval from a member of the team
  • The code builds and tests pass locally (also verified by our automated build checks)
  • Commit messages follow this format:
        Summary of the changes
        - Detail 1
        - Detail 2

        Fixes #bugnumber
  • Tests for the changes have been added (for bug fixes / features)
  • Code follows the same patterns and style as existing code in this repo

Summary of the changes

  • This PR adds a fix so that view indexes in SQL Server are correctly included when scaffolding a database schema.
  • A CTE was required here since the column temporal_type was not present either in sys.views or sys.object, and the column was required to be present since it was part of the table filter.

Fixes #37345

@sarbas33 sarbas33 requested a review from a team as a code owner February 1, 2026 17:15
@sarbas33 sarbas33 marked this pull request as draft February 1, 2026 19:01
@sarbas33 sarbas33 changed the title Fix SQL Server scaffold view index Fix View Indexes not Scaffolded in Sql Server Feb 1, 2026
@sarbas33 sarbas33 force-pushed the fix-sqlserver-scaffold-view-index branch 2 times, most recently from 259c24d to 30a2c5d Compare February 2, 2026 05:09
@sarbas33 sarbas33 force-pushed the fix-sqlserver-scaffold-view-index branch from 8b122ce to d108c49 Compare February 2, 2026 14:28
@sarbas33 sarbas33 marked this pull request as ready for review February 2, 2026 16:36
@AndriySvyryd AndriySvyryd self-assigned this Feb 3, 2026
@AndriySvyryd
Copy link
Member

AndriySvyryd commented Feb 3, 2026

@sarbas33 Please file an issue to track what is being fixed

@sarbas33
Copy link
Author

sarbas33 commented Feb 3, 2026

@AndriySvyryd . This PR fixes #37345.

@ErikEJ
Copy link
Contributor

ErikEJ commented Feb 3, 2026

@sarbas33 Why is scaffolding of indexes important?

Have you tested the performance of the updated query (compared with the current one) against a sizeable database?

@sarbas33
Copy link
Author

sarbas33 commented Feb 3, 2026

@ErikEJ Scaffolding indexes on views may be required only for correctness of metadata.

Regarding performance, I tested on database with 10000 tables and 1000 views, new query introduces a small one-time compile cost (~150ms) due to the CTE, but execution time is comparable or slightly improved. Since this runs only during scaffolding, the performance impact can be considered negligible.

@AndriySvyryd AndriySvyryd merged commit 69eaf15 into dotnet:release/10.0 Feb 4, 2026
7 checks passed
@AndriySvyryd
Copy link
Member

AndriySvyryd commented Feb 4, 2026

Thanks for your contribution!

@dotnet-maestro dotnet-maestro bot mentioned this pull request Feb 4, 2026
Merged
@ErikEJ
Copy link
Contributor

ErikEJ commented Feb 5, 2026

@AndriySvyryd Why was this merged into the release branch?

@ErikEJ ErikEJ mentioned this pull request Feb 5, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AndriySvyryd AndriySvyryd AndriySvyryd approved these changes

Assignees

@AndriySvyryd AndriySvyryd

Labels

community-contribution

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sarbas33 @AndriySvyryd @ErikEJ